feat: move getGrpcClient to ActionContext, #617#637
Merged
johanandren merged 1 commit intomainfrom Oct 15, 2021
Merged
Conversation
* because we don't want to encourage async (or even worse blocking) calls in other components * we don't have async effect in other components
patriknw
commented
Oct 15, 2021
| * service or an external service where connection details are configured under | ||
| * `akka.grpc.client.[service-name]` in `application.conf`. | ||
| */ | ||
| <T> T getGrpcClient(Class<T> clientClass, String service); |
Contributor
Author
There was a problem hiding this comment.
might not be needed in the ActionCreationContext, but doesn't hurt if someone prefer to grab it in the constructor
johanandren
approved these changes
Oct 15, 2021
Contributor
johanandren
left a comment
johanandren
left a comment
There was a problem hiding this comment.
LGTM, good closing down that path to bad entities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
calls in other components
Fixes #617